[all-commits] [llvm/llvm-project] d4c647: [mlir][vector] Update tests for collapse 1/n (nfc)...

Andrzej Warzyński via All-commits all-commits at lists.llvm.org
Tue Jun 11 05:57:07 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d4c6478cf2c0a8e2bebc66eb7eff4d0f11626d9a
      https://github.com/llvm/llvm-project/commit/d4c6478cf2c0a8e2bebc66eb7eff4d0f11626d9a
  Author: Andrzej Warzyński <andrzej.warzynski at arm.com>
  Date:   2024-06-11 (Tue, 11 Jun 2024)

  Changed paths:
    M mlir/test/Dialect/Vector/vector-transfer-collapse-inner-most-dims.mlir

  Log Message:
  -----------
  [mlir][vector] Update tests for collapse 1/n (nfc) (#94490)

The main goal of this PR (and subsequent PRs), is to add more tests with
scalable vectors to:
  * vector-transfer-collapse-inner-most-dims.mlir

There's quite a few cases to consider, hence this is split into multiple
PRs. In this PR, the very first test is complemented with all the
possible combinations:
  * scalable (rather than fixed) unit trailing dim,
  * dynamic (rather than static) trailing dim in the source memref.

Also,
  * `@leading_scalable_dimension_transfer_read` and
    `@trailing_scalable_one_dim_transfer_read`,

are replaced with:
  * `@contiguous_inner_most_scalable_inner_dim` and
    `@negative_scalable_unit_dim`,

respectively, and added to the list above (i.e. alongside other
variations for the very first test).

In addition:
  * "_view" is removed from function names (it's not clear to me what it
    was meant to signify)
  * extra comments are added to separate tests for vector.transfer_read
    and vector.transfer_write

NOTE: This PR is limited to tests for `vector.transfer_read`.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list