[all-commits] [llvm/llvm-project] 4ea392: [mlir][Transforms] Dialect Conversion: Simplify bl...

[Matthias Springer via All-commits]

  Branch: refs/heads/users/matthias-springer/dialect_conversion_block_api
  Home:   https://github.com/llvm/llvm-project
  Commit: 4ea392009450abc5a6c91efcdbf5e99d061ba224
      https://github.com/llvm/llvm-project/commit/4ea392009450abc5a6c91efcdbf5e99d061ba224
  Author: Matthias Springer <mspringer at nvidia.com>
  Date:   2024-06-08 (Sat, 08 Jun 2024)

  Changed paths:
    M mlir/docs/DialectConversion.md
    M mlir/include/mlir/Transforms/DialectConversion.h
    M mlir/lib/Conversion/SCFToSPIRV/SCFToSPIRV.cpp
    M mlir/lib/Dialect/Linalg/Transforms/Detensorize.cpp
    M mlir/lib/Transforms/Utils/DialectConversion.cpp
    M mlir/test/lib/Dialect/Test/TestPatterns.cpp

  Log Message:
  -----------
  [mlir][Transforms] Dialect Conversion: Simplify block conversion API

This commit simplifies and improves documentation for the part of the `ConversionPatternRewriter` API that deals with signature conversions.

There are now two public functions for signature conversion:
* `applySignatureConversion` converts a single block signature.
* `convertRegionTypes` converts all block signatures of a region.

Note: `convertRegionTypes` could be renamed to `applySignatureConversion` (overload) in the future.

Also clarify when a type converter and/or signature conversion object is needed and for what purpose.

>From a functional perspective, this change is NFC. However, the public API changes, thus not marking as NFC.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications