[all-commits] [llvm/llvm-project] 6b3e00: [mlir][Transforms][NFC] `GreedyPatternRewriteDrive...

Matthias Springer via All-commits all-commits at lists.llvm.org
Sat Jun 8 01:26:39 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6b3e0002dfe0029487fc2f8f11f5d5fdc07a5e11
      https://github.com/llvm/llvm-project/commit/6b3e0002dfe0029487fc2f8f11f5d5fdc07a5e11
  Author: Matthias Springer <me at m-sp.org>
  Date:   2024-06-08 (Sat, 08 Jun 2024)

  Changed paths:
    M mlir/include/mlir/IR/PatternMatch.h
    M mlir/lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp

  Log Message:
  -----------
  [mlir][Transforms][NFC] `GreedyPatternRewriteDriver`: Use composition instead of inheritance (#92785)

This commit simplifies the design of the `GreedyPatternRewriterDriver`
class. This class used to inherit from both `PatternRewriter` and
`RewriterBase::Listener` and then attached itself as a listener.

In the new design, the class has a `PatternRewriter` field instead of
inheriting from `PatternRewriter`, which is generally perferred in
object-oriented programming.

---------

Co-authored-by: Markus Böck <markus.boeck02 at gmail.com>



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list