[all-commits] [llvm/llvm-project] 435dd9: Add AllowRepeats to SBCommandInterpreterRunOptions...

[jimingham via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 435dd9746107e13c2ad019be3bd34815f7d2360d
      https://github.com/llvm/llvm-project/commit/435dd9746107e13c2ad019be3bd34815f7d2360d
  Author: jimingham <jingham at apple.com>
  Date:   2024-06-07 (Fri, 07 Jun 2024)

  Changed paths:
    M lldb/bindings/interface/SBCommandInterpreterRunOptionsDocstrings.i
    M lldb/include/lldb/API/SBCommandInterpreterRunOptions.h
    M lldb/include/lldb/Interpreter/CommandInterpreter.h
    M lldb/source/API/SBCommandInterpreterRunOptions.cpp
    M lldb/source/Interpreter/CommandInterpreter.cpp
    M lldb/test/API/python_api/interpreter/TestRunCommandInterpreterAPI.py

  Log Message:
  -----------
  Add AllowRepeats to SBCommandInterpreterRunOptions. (#94786)

This is useful if you have a transcript of a user session and want to
rerun those commands with RunCommandInterpreter. The same functionality
is also useful in testing.

I'm adding it primarily for the second reason. In a subsequent patch,
I'm adding the ability to Python based commands to provide their
"auto-repeat" command. Among other things, that will allow potentially
state destroying user commands to prevent auto-repeat. Testing this with
Shell or pexpect tests is not nearly as accurate or convenient as using
RunCommandInterpreter, but to use that I need to allow auto-repeat.

I think for consistency's sake, having interactive sessions always do
auto-repeats is the right choice, though that's a lightly held
opinion...



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications