[all-commits] [llvm/llvm-project] 3fefb3: [BOLT][NFC] Infailable fns return void (#92018)

[Nathan Sidwell via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3fefb3c598db995433093ed158c08368809b3f78
      https://github.com/llvm/llvm-project/commit/3fefb3c598db995433093ed158c08368809b3f78
  Author: Nathan Sidwell <nathan at acm.org>
  Date:   2024-06-07 (Fri, 07 Jun 2024)

  Changed paths:
    M bolt/include/bolt/Core/MCPlusBuilder.h
    M bolt/lib/Passes/VeneerElimination.cpp
    M bolt/lib/Target/AArch64/AArch64MCPlusBuilder.cpp
    M bolt/lib/Target/RISCV/RISCVMCPlusBuilder.cpp
    M bolt/lib/Target/X86/X86MCPlusBuilder.cpp

  Log Message:
  -----------
  [BOLT][NFC] Infailable fns return void (#92018)

Both `reverseBranchCondition` and `replaceBranchTarget` return a success boolean. But all-but-one caller ignores the return value, and the exception emits a fatal error on failure.

Thus, just return nothing.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications