[all-commits] [llvm/llvm-project] 505cd1: [SPIR-V] Add validation to the test case with get_...

Vyacheslav Levytskyy via All-commits all-commits at lists.llvm.org
Thu Jun 6 07:31:31 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 505cd125a1edad4e59776e03e9a755aa598ed6f2
      https://github.com/llvm/llvm-project/commit/505cd125a1edad4e59776e03e9a755aa598ed6f2
  Author: Vyacheslav Levytskyy <vyacheslav.levytskyy at intel.com>
  Date:   2024-06-06 (Thu, 06 Jun 2024)

  Changed paths:
    M llvm/lib/Target/SPIRV/SPIRVBuiltins.cpp
    M llvm/lib/Target/SPIRV/SPIRVBuiltins.td
    M llvm/lib/Target/SPIRV/SPIRVEmitIntrinsics.cpp
    M llvm/lib/Target/SPIRV/SPIRVGlobalRegistry.h
    M llvm/lib/Target/SPIRV/SPIRVPreLegalizer.cpp
    M llvm/test/CodeGen/SPIRV/event-wait-ptr-type.ll
    M llvm/test/CodeGen/SPIRV/passes/SPIRVEmitIntrinsics-no-duplicate-spv_assign_type.ll
    A llvm/test/CodeGen/SPIRV/transcoding/OpGroupAsyncCopy-strided.ll
    M llvm/test/CodeGen/SPIRV/transcoding/check_ro_qualifier.ll

  Log Message:
  -----------
  [SPIR-V] Add validation to the test case with get_image_array_size/get_image_dim calls (#94467)

This PR is to add validation to the test case with
get_image_array_size/get_image_dim calls
(transcoding/check_ro_qualifier.ll). This test case didn't pass
validation because of invalid emission of OpCompositeExtract instruction
(Result Type must be the same type as Composite.).

In order to fix the problem this PR improves type inference in general
and partially addresses issues:
* https://github.com/llvm/llvm-project/issues/91998
* https://github.com/llvm/llvm-project/issues/91997

A reproducer from the description of the latter issue is added as a new
test case as a part of this PR.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list