[all-commits] [llvm/llvm-project] afc729: [SDPatternMatch] Do not use std::forward and rvalu...

[Nikita Popov via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: afc7292626e193a2b09b81d227eac90428f0abe3
      https://github.com/llvm/llvm-project/commit/afc7292626e193a2b09b81d227eac90428f0abe3
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2024-06-06 (Thu, 06 Jun 2024)

  Changed paths:
    M llvm/include/llvm/CodeGen/SDPatternMatch.h

  Log Message:
  -----------
  [SDPatternMatch] Do not use std::forward and rvalue references (NFC) (#93806)

The m_ZExtOrSelf() family of matchers currently incorrectly calls
std::forward twice on the same value. However, just removing those causes
other complications, because then template arguments get incorrectly
inferred to const references instead of the underlying value types.
Things become a mess.

Instead, just completely remove the use of std::forward and rvalue
references from SDPatternMatch. I don't think they really provide value
in this context, especially as they're not used consistently in the
first place.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications