[all-commits] [llvm/llvm-project] 59e916: [lldb] UpdateFormatsIfNeeded should respect the dy...

Augusto Noronha via All-commits all-commits at lists.llvm.org
Wed Jun 5 11:08:58 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 59e9160ac8c906c5448c2094cd28cb5bc7678a3f
      https://github.com/llvm/llvm-project/commit/59e9160ac8c906c5448c2094cd28cb5bc7678a3f
  Author: Augusto Noronha <augusto2112 at me.com>
  Date:   2024-06-05 (Wed, 05 Jun 2024)

  Changed paths:
    M lldb/source/Core/ValueObject.cpp

  Log Message:
  -----------
  [lldb] UpdateFormatsIfNeeded should respect the dynamic value type (#93262)

UpdateFormatsIfNeeded has hardcoded the call to GetFormat with no
dynamic values. GetFormat will try to find the synthetic children of the
ValueObject, and passing the wrong one can fail, which can be bad for
performance but should not be user visible. Fix the performace bug by
passing the dynamic value type of the ValueObject.

rdar://122506593



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list