[all-commits] [llvm/llvm-project] a0cdd3: [libc++] [test] Consistently use `REQUIRES: has-un...

[Stephan T. Lavavej via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a0cdd32b79318fc45e07bc0cef7e57308b1166ed
      https://github.com/llvm/llvm-project/commit/a0cdd32b79318fc45e07bc0cef7e57308b1166ed
  Author: Stephan T. Lavavej <stl at nuwen.net>
  Date:   2024-06-05 (Wed, 05 Jun 2024)

  Changed paths:
    M libcxx/test/libcxx/assertions/modes/enabling_assertions_enables_extensive_mode.pass.cpp
    M libcxx/test/libcxx/assertions/modes/override_with_debug_mode.pass.cpp
    M libcxx/test/libcxx/assertions/modes/override_with_extensive_mode.pass.cpp
    M libcxx/test/libcxx/assertions/modes/override_with_fast_mode.pass.cpp
    M libcxx/test/libcxx/assertions/modes/override_with_unchecked_mode.pass.cpp
    M libcxx/test/libcxx/containers/sequences/deque/asan_caterpillar.pass.cpp
    M libcxx/test/std/algorithms/pstl.exception_handling.pass.cpp

  Log Message:
  -----------
  [libc++] [test] Consistently use `REQUIRES: has-unix-headers` (#94122)

There were 7 occurrences of `UNSUPPORTED: !has-unix-headers`, versus 212
occurrences of `REQUIRES: has-unix-headers`.

I don't completely understand how libc++ uses UNSUPPORTED versus
REQUIRES, but it seems better to be consistent, and to avoid the double
negation in "this is unsupported if we don't have unix headers".

(This came to my attention because of the single occurrence in
`libcxx/test/std`. Our MSVC-internal test harness isn't aware of lit
features, so we teach it to skip tests via the incredibly primitive
method of searching for specific comments, so I had to deal with this
comment inconsistency.)



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications