[all-commits] [llvm/llvm-project] 99b258: Reland "[Win32][ELF] Make CodeView a DebugInfoForm...

[Phoebe Wang via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 99b2581a4b162b718925b791433faaa108745a90
      https://github.com/llvm/llvm-project/commit/99b2581a4b162b718925b791433faaa108745a90
  Author: Phoebe Wang <phoebe.wang at intel.com>
  Date:   2024-06-05 (Wed, 05 Jun 2024)

  Changed paths:
    M clang/lib/Driver/ToolChains/MSVC.h
    M clang/test/Driver/cl-options.c
    M clang/test/Driver/cl-outputs.c
    M clang/test/Driver/gcodeview-command-line.c
    M clang/test/Driver/gcodeview-ghash.c
    A clang/test/Misc/win32-elf.c

  Log Message:
  -----------
  Reland "[Win32][ELF] Make CodeView a DebugInfoFormat only for COFF format", second try (#88245)

This is a second try to reland
https://github.com/llvm/llvm-project/pull/87149.

The previous commit exposed failures on some targets. The reason is only
a few targets support COFF ObjectFormatType on Windows:
https://github.com/llvm/llvm-project/blob/main/llvm/lib/TargetParser/Triple.cpp#L835-L842

With https://github.com/llvm/llvm-project/pull/87149, the targets don't
support COFF will report "warning: argument unused during compilation:
'-gcodeview-command-line' [-Wunused-command-line-argument]" in the test
gcodeview-command-line.c

I was thinking `REQUIRES: *-registered-target` could solve the problem,
but it didn't. We need to check the actual triple instead of just
`*-registered-target`.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications