[all-commits] [llvm/llvm-project] 0cb66a: [llvm-readobj][COFF] Consistent PDBGUID Formatting...

[Miguel A. Arroyo via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0cb66a7bd52ee51a6b43c42fec22082b26365e37
      https://github.com/llvm/llvm-project/commit/0cb66a7bd52ee51a6b43c42fec22082b26365e37
  Author: Miguel A. Arroyo <mayanez at users.noreply.github.com>
  Date:   2024-06-04 (Tue, 04 Jun 2024)

  Changed paths:
    M lld/test/COFF/rsds.test
    M llvm/test/tools/llvm-readobj/COFF/debug-directory.test
    M llvm/tools/llvm-readobj/COFFDumper.cpp

  Log Message:
  -----------
  [llvm-readobj][COFF] Consistent PDBGUID Formatting (#94256)

## Consistent PDB GUID in `llvm-readobj`

Currently, the PDB GUID is shown as a byte array:
`PDBGUID: (D8 4C 88 D9 26 15 1F 11 4C 4C 44 20 50 44 42 2E)`

This is inconsistent with `llvm-pdbutil` (e.g. `llvm-pdbutil dump
--summary`) which shows it as a hexadecimal string.
Additionally, `yaml2obj` uses the same hexadecimal string format.

In general, the hexadecimal string is the common representation for PDB
GUIDs on Windows.

This PR changes it to be consistent as shown below:
`PDBGUID: {D9884CD8-1526-111F-4C4C-44205044422E}`



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications