[all-commits] [llvm/llvm-project] f9db0d: [cmake][runtimes] Add missing dependency on LLVMgo...

[Nikita Popov via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f9db0d2c43d2956813fab8309def6b23adc73f35
      https://github.com/llvm/llvm-project/commit/f9db0d2c43d2956813fab8309def6b23adc73f35
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2024-06-04 (Tue, 04 Jun 2024)

  Changed paths:
    M llvm/cmake/modules/LLVMExternalProjectUtils.cmake

  Log Message:
  -----------
  [cmake][runtimes] Add missing dependency on LLVMgold.so (#94199)

When doing a runtimes build with LTO using ld.bfd (or ld.gold), the
build starts failing with ninja 1.12, which added a new critical path
scheduler. The reason is that LLVMgold.so is not available yet at the
point where runtimes start being build, leading to configuration
failures in the nested cmake invocation.

Fix this by adding an explicit dependency on LLVMgold.so if it is
available. (It may not always be necessary, e.g. if the used linker is
lld, but it would be hard to detect when exactly it may or may not be
needed, so always adding the dependency is safer.)



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications