[all-commits] [llvm/llvm-project] ffec63: [cmake] Pass -resource-dir to external projects as...

Raul Tambre via All-commits all-commits at lists.llvm.org
Mon Jun 3 09:46:27 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ffec63b6a54f719976443cc17b6226030be17c52
      https://github.com/llvm/llvm-project/commit/ffec63b6a54f719976443cc17b6226030be17c52
  Author: Raul Tambre <raul at tambre.ee>
  Date:   2024-06-03 (Mon, 03 Jun 2024)

  Changed paths:
    M llvm/cmake/modules/LLVMExternalProjectUtils.cmake

  Log Message:
  -----------
  [cmake] Pass -resource-dir to external projects as CMAKE_<LANG>_FLAGS_INIT instead of as a force override (#87330)

It's useful to use toolchain files for configuring runtimes builds.
Setting `CMAKE_<LANG>_FLAGS` is however forceful and precludes initialization from the _INIT variant meant to be set by toolchains.
The toolchain file still needs to append instead of just setting and be idempotent (`include_guard()`), but this way at least a special toolchain to account for LLVM won't be required.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list