[all-commits] [llvm/llvm-project] 0e62d5: [clang-tidy] Fix assert in modernize-use-std-forma...

[Mike Crowe via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0e62d5cf55479981da5e05e406bbca4afb3cdc4f
      https://github.com/llvm/llvm-project/commit/0e62d5cf55479981da5e05e406bbca4afb3cdc4f
  Author: Mike Crowe <mac at mcrowe.com>
  Date:   2024-06-03 (Mon, 03 Jun 2024)

  Changed paths:
    M clang-tools-extra/clang-tidy/modernize/UseStdFormatCheck.cpp
    M clang-tools-extra/clang-tidy/modernize/UseStdPrintCheck.cpp
    M clang-tools-extra/clang-tidy/utils/FormatStringConverter.cpp
    M clang-tools-extra/clang-tidy/utils/Matchers.h
    M clang-tools-extra/docs/ReleaseNotes.rst
    M clang-tools-extra/test/clang-tidy/checkers/modernize/use-std-format-custom.cpp
    M clang-tools-extra/test/clang-tidy/checkers/modernize/use-std-print-custom.cpp

  Log Message:
  -----------
  [clang-tidy] Fix assert in modernize-use-std-format/print (#94104)

Ensure that FormatStringConverter's constructor fails with a sensible
error message rather than asserting if the format string is not a narrow
string literal.

Also, ensure that we don't even get that far in modernize-use-std-print
and modernize-use-std-format by checking that the format string
parameter is a char pointer.

Fixes #92896



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications