[all-commits] [llvm/llvm-project] a41a20: [NFC] [C++20] [Modules] [Reduced BMI] Reorder Emit...

Chuanqi Xu via All-commits all-commits at lists.llvm.org
Mon Jun 3 00:48:49 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a41a20bd47968b16bb84761578628752080e9f24
      https://github.com/llvm/llvm-project/commit/a41a20bd47968b16bb84761578628752080e9f24
  Author: Chuanqi Xu <yedeng.yd at linux.alibaba.com>
  Date:   2024-06-03 (Mon, 03 Jun 2024)

  Changed paths:
    M clang/lib/Frontend/FrontendActions.cpp

  Log Message:
  -----------
  [NFC] [C++20] [Modules] [Reduced BMI] Reorder Emitting reduced BMI and normal BMI for named modules

When we generate the reduced BMI on the fly, the order of the emitting
phase is different within `-emit-obj` and `-emit-module-interface`.
Although this is meant to be fine, we observed it in
https://github.com/llvm/llvm-project/issues/93859 (that the different phase order may cause problems).
Also it turns out to be a different fundamental reason to the orders.

But it might be fine to make the order of emitting reducing BMI at first
to avoid such confusions in the future.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list