[all-commits] [llvm/llvm-project] 2b1dfd: [DAG] Replace getValid*ShiftAmountConstant helpers...

[Simon Pilgrim via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2b1dfd2b35b5684c8af85206e199152bd6ac3a8d
      https://github.com/llvm/llvm-project/commit/2b1dfd2b35b5684c8af85206e199152bd6ac3a8d
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2024-06-01 (Sat, 01 Jun 2024)

  Changed paths:
    M llvm/include/llvm/CodeGen/SelectionDAG.h
    M llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
    M llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
    M llvm/lib/Target/X86/X86ISelLowering.cpp
    M llvm/test/CodeGen/PowerPC/pr44183.ll

  Log Message:
  -----------
  [DAG] Replace getValid*ShiftAmountConstant helpers with getValid*ShiftAmount helpers to support KnownBits analysis (#93182)

The getValidShiftAmountConstant/getValidMinimumShiftAmountConstant/getValidMaximumShiftAmountConstant helpers only worked with constant shift amounts, which could be problematic after type legalization (e.g. v2i64 might be partially scalarized or split into v4i32 on some targets such as 32-bit x86, Thumb2 MVE).

This patch proposes we generalize these helpers to work with ConstantRange+KnownBits if a scalar/buildvector constant isn't available.

Most restrictions are the same - the helper fails if any shift amount is out of bounds, getValidShiftConstant must be a specific constant uniform etc.

However, getValidMinimumShiftAmount/getValidMaximumShiftAmount now can return bounds values that aren't values in the actual data, as they are based off the common KnownBits of every vector element.

This addresses feedback on #92096



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications