[all-commits] [llvm/llvm-project] 37019c: [PGO] Preserve analysis results when nothing was i...

[Pavel Samolysov via All-commits]

  Branch: refs/heads/users/psamolysov/pgo-instrument-when-at-least-one-definition
  Home:   https://github.com/llvm/llvm-project
  Commit: 37019cf6165d1d947b06995e4937e958de72d3b2
      https://github.com/llvm/llvm-project/commit/37019cf6165d1d947b06995e4937e958de72d3b2
  Author: Pavel Samolysov <samolisov at gmail.com>
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
    M llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp
    M llvm/test/Transforms/PGOProfile/declarations_only.ll
    M llvm/test/Transforms/PGOProfile/global_variables_only.ll
    A llvm/test/Transforms/PGOProfile/no_global_variables.ll
    M llvm/unittests/Transforms/Instrumentation/PGOInstrumentationTest.cpp

  Log Message:
  -----------
  [PGO] Preserve analysis results when nothing was instrumented

The 'PGOInstrumentationGen' pass should preserve all analysis results
when nothing was actually instrumented. Currently, only modules that
contain at least a single function definition are instrumented. When a
module contains only function declarations and, optionally, global
variable definitions (a module for the regular-LTO phase for thin-LTO
when LTOUnit splitting is enabled, for example), such module is not
instrumented (yet?) and there is no reason to introduce the
'__llvm_profile_raw_version' variable into the module.


  Commit: e6a918ea937465483ad942001a220ee6742aea4f
      https://github.com/llvm/llvm-project/commit/e6a918ea937465483ad942001a220ee6742aea4f
  Author: Pavel Samolysov <samolisov at gmail.com>
  Date:   2024-05-31 (Fri, 31 May 2024)

  Changed paths:
    M llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp
    M llvm/test/Transforms/PGOProfile/declarations_only.ll
    M llvm/test/Transforms/PGOProfile/global_variables_only.ll
    R llvm/test/Transforms/PGOProfile/no_global_variables.ll
    M llvm/unittests/Transforms/Instrumentation/PGOInstrumentationTest.cpp

  Log Message:
  -----------
  Revert "[PGO] Generate __llvm_profile_raw_version only when instrumented"

This reverts commit 5d5ead1dbd9aac486aada3acf81cc09464ab7bae.


Compare: https://github.com/llvm/llvm-project/compare/37019cf6165d%5E...e6a918ea9374

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications