[all-commits] [llvm/llvm-project] f38ebe: [lldb-dap] Don't call GetNumChildren on non-indexe...

[Pavel Labath via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f38ebec7106fd541046d502be0f79a4dda1a89b0
      https://github.com/llvm/llvm-project/commit/f38ebec7106fd541046d502be0f79a4dda1a89b0
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2024-05-30 (Thu, 30 May 2024)

  Changed paths:
    A lldb/test/API/tools/lldb-dap/variables/children/Makefile
    A lldb/test/API/tools/lldb-dap/variables/children/TestDAP_variables_children.py
    A lldb/test/API/tools/lldb-dap/variables/children/formatter.py
    A lldb/test/API/tools/lldb-dap/variables/children/main.cpp
    M lldb/tools/lldb-dap/JSONUtils.cpp

  Log Message:
  -----------
  [lldb-dap] Don't call GetNumChildren on non-indexed synthetic variables (#93534)

A synthetic child provider might need to do considerable amount of work
to compute the number of children. lldb-dap is currently calling that
for all synthethic variables, but it's only actually using the value for
values which it deems to be "indexed" (which is determined by looking at
the name of the first child). This patch reverses the logic so that
GetNumChildren is only called for variables with a suitable first child.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications