[all-commits] [llvm/llvm-project] 53d79f: [lldb/DWARF] Bypass the compres^Wconstruction of D...

[Pavel Labath via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 53d79feec93ef99e2ba0ac8cfc6cf2f81d28bf8a
      https://github.com/llvm/llvm-project/commit/53d79feec93ef99e2ba0ac8cfc6cf2f81d28bf8a
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2024-05-29 (Wed, 29 May 2024)

  Changed paths:
    M lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp
    M lldb/source/Plugins/SymbolFile/DWARF/DWARFIndex.cpp
    M lldb/source/Plugins/SymbolFile/DWARF/DWARFIndex.h
    M lldb/source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp
    M lldb/source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.h

  Log Message:
  -----------
  [lldb/DWARF] Bypass the compres^Wconstruction of DIERefs in debug_names (#93296)

DebugNamesDWARFIndex was jumping through hoops to construct a DIERef
from an index entry only to jump through them back a short while later
to construct a DWARFDIE.

This used to be necessary as the index lookup was a two stage process,
where we first enumerated all matches, and then examined them (so it was
important that the enumeration was cheap -- does not trigger unnecessary
parsing). However, now that the processing is callback based, we are
always immediately examining the DWARFDIE right after finding the entry,
and the DIERef just gets in the way.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications