[all-commits] [llvm/llvm-project] cbf6e9: [clang codegen] Delete unnecessary GEP cleanup cod...

[Eli Friedman via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: cbf6e93ceee7b9de2b7c3e7e8cea3a972eda0e75
      https://github.com/llvm/llvm-project/commit/cbf6e93ceee7b9de2b7c3e7e8cea3a972eda0e75
  Author: Eli Friedman <efriedma at quicinc.com>
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
    M clang/lib/CodeGen/CGExprAgg.cpp
    M clang/test/CodeGenCXX/no-unique-address.cpp

  Log Message:
  -----------
  [clang codegen] Delete unnecessary GEP cleanup code. (#90303)

There's some code in AggExprEmitter::VisitCXXParenListOrInitListExpr to
try to do early cleanup for GEPs for fields that aren't accessed. But
it's unlikely to actually save significant compile-time, and it's subtly
wrong in cases where EmitLValueForFieldInitialization() doesn't create a
GEP. So just delete the code.

Fixes #88077. Fixes #89547.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications