[all-commits] [llvm/llvm-project] 5bfe4b: [mlir][arith] Disallow casting tensor dimensions (...

[Jakub Kuderski via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5bfe4b93e15ad38f211c5dec64be0eeaa4c8e914
      https://github.com/llvm/llvm-project/commit/5bfe4b93e15ad38f211c5dec64be0eeaa4c8e914
  Author: Jakub Kuderski <jakub at nod-labs.com>
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
    M mlir/include/mlir/Dialect/Arith/IR/ArithOps.td
    M mlir/test/Dialect/Arith/canonicalize.mlir
    M mlir/test/Dialect/Arith/invalid.mlir

  Log Message:
  -----------
  [mlir][arith] Disallow casting tensor dimensions (#93349)

Tighten the verifier for arith cast ops to disallow changing tensor
dimensions, e.g., static to dynamic. After this change:
* `arith.cast_op %x : tensor<4xi32> to tensor<4xf32>` remains valid
* `arith.cast_op %x : tensor<4xi32> to tensor<?xf32>` becomes invalid
* `arith.cast_op %x : tensor<?xi32> to tensor<4xf32>` becomes invalid

This is mostly to simplify the op semantics. See the discussion thread
for more context:
https://discourse.llvm.org/t/rfc-remove-arith-math-ops-on-tensors/74357/63.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications