[all-commits] [llvm/llvm-project] 5a23d3: [Sample Profile] Check hot callsite threshold when...

[William Junda Huang via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5a23d31c5033dcb41d374692ed26d87ed8e2665a
      https://github.com/llvm/llvm-project/commit/5a23d31c5033dcb41d374692ed26d87ed8e2665a
  Author: William Junda Huang <williamjhuang at google.com>
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
    M llvm/lib/Transforms/IPO/SampleProfile.cpp
    A llvm/test/Transforms/SampleProfile/Inputs/inline-hot-callsite-threshold.prof
    A llvm/test/Transforms/SampleProfile/inline-hot-callsite-threshold.ll
    M llvm/test/Transforms/SampleProfile/pseudo-probe-inline.ll
    M llvm/test/Transforms/SampleProfile/remarks.ll

  Log Message:
  -----------
  [Sample Profile] Check hot callsite threshold when inlining a function with a sample profile (#93286)

Currently if a callsite is hot as determined by the sample profile, it
is unconditionally inlined barring invalid cases (such as recursion).
Inline cost check should still apply because a function's hotness and
its inline cost are two different things.
For example if a function is calling another very large function
multiple times (at different code paths), the large function should not
be inlined even if its hot.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications