[all-commits] [llvm/llvm-project] d1d863: [lldb] Remove lldbassert in AppleObjCTypeEncodingP...

[Jonas Devlieghere via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d1d863c012cf3d5b407ae06d23a5628ec9510b7c
      https://github.com/llvm/llvm-project/commit/d1d863c012cf3d5b407ae06d23a5628ec9510b7c
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
    M lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTypeEncodingParser.cpp

  Log Message:
  -----------
  [lldb] Remove lldbassert in AppleObjCTypeEncodingParser (#93332)

AppleObjCTypeEncodingParser::BuildObjCObjectPointerType currently
contains an lldbassert to detect situations where we have a forward
declaration without a definition. According to the accompanying comment,
its purpose is to catch "weird cases" during test suite runs.

However, because this is an lldbassert, we show a scary message to our
users who think this is a problem and report the issue to us.
Unfortunately those reports aren't very actionable without a way to know
the name of the type.

This patch changes the lldbassert to a regular assert and emits a log
message to the types log when this happens.

rdar://127439898



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications