[all-commits] [llvm/llvm-project] 7bea41: LoopIdiomRecognize: strip bad TODO (NFC) (#92890)

[Ramkumar Ramachandra via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7bea41e173367e2a535bd2188fd652a2ca267b90
      https://github.com/llvm/llvm-project/commit/7bea41e173367e2a535bd2188fd652a2ca267b90
  Author: Ramkumar Ramachandra <r at artagnon.com>
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
    M llvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp

  Log Message:
  -----------
  LoopIdiomRecognize: strip bad TODO (NFC) (#92890)

There are several reasons why handling powi in LoopIdiomRecognize is a
bad idea:

- powi corresponds to a GCC builtin that is only defined for C int
(which is i32 for most targets).
- powi isn't always lowered by targets correctly for non-i32 parameters.
Several targets fail to compile llvm.powi.f32.i16, for example.
- Unlike memcpy and memset, which tend to be important enough internal
intrinsics that you have to handle them correctly even in freestanding
modes, powi isn't.

Strip this bad TODO to avoid misleading contributors.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications