[all-commits] [llvm/llvm-project] 42c402: [AMDGPU][SplitModule] Keep looking for more depend...

Pierre van Houtryve via All-commits all-commits at lists.llvm.org
Mon May 27 23:19:15 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 42c4027729ac7dbfb732a361ab8085d4af0a7a0a
      https://github.com/llvm/llvm-project/commit/42c4027729ac7dbfb732a361ab8085d4af0a7a0a
  Author: Pierre van Houtryve <pierre.vanhoutryve at amd.com>
  Date:   2024-05-28 (Tue, 28 May 2024)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPUSplitModule.cpp
    M llvm/test/tools/llvm-split/AMDGPU/kernels-dependency-indirect.ll

  Log Message:
  -----------
  [AMDGPU][SplitModule] Keep looking for more dependencies after finding an indirect call (#93480)

This is just something I noticed while going over this pass logic one
more time and didn't cause issues (yet). If we find an indirect call, we
stop looking assuming we added all functions to the list, but if not all
functions in the module were indirectly callable, some may still be
missing.

Just to be safe, keep looking until we did everything we could to find
dependencies, so we don't accidentally miss one.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list