[all-commits] [llvm/llvm-project] 21a39d: [XRay][compiler-rt] Fix oob memory access in FDR B...

Ricky Zhou via All-commits all-commits at lists.llvm.org
Mon May 27 16:33:18 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 21a39dfb17a4931d99d9a6d561d596c841d9197a
      https://github.com/llvm/llvm-project/commit/21a39dfb17a4931d99d9a6d561d596c841d9197a
  Author: Ricky Zhou <ricky at rzhou.org>
  Date:   2024-05-27 (Mon, 27 May 2024)

  Changed paths:
    M compiler-rt/lib/xray/xray_buffer_queue.h

  Log Message:
  -----------
  [XRay][compiler-rt] Fix oob memory access in FDR BufferQueue iterator (#90940)

Before this change, the FDR BufferQueue iterator could access oob memory
due to checks of the form `!Buffers[Offset].Used && Offset != Max`. This
allows access to `Buffers[Max]`, which is past the end of the `Buffers`
array. This can lead to crashes when that memory is not mapped. Fix this
by testing `Offset != Max` first.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list