[all-commits] [llvm/llvm-project] 90e33e: [clang-scan-deps] Expand response files before the...

[Alexandre Ganea via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 90e33e20a594b8a404af1df93b629137cb605a21
      https://github.com/llvm/llvm-project/commit/90e33e20a594b8a404af1df93b629137cb605a21
  Author: Alexandre Ganea <aganea at havenstudios.com>
  Date:   2024-05-24 (Fri, 24 May 2024)

  Changed paths:
    M clang/lib/Driver/ToolChains/Clang.cpp
    A clang/test/ClangScanDeps/response-file-clang-cl.c
    M clang/test/Driver/cl-options.c
    M clang/tools/clang-scan-deps/ClangScanDeps.cpp

  Log Message:
  -----------
  [clang-scan-deps] Expand response files before the argument adjuster (#89950)

Previously, since response (.rsp) files weren't expanded at the very
beginning of clang-scan-deps, we only parsed the command-line as
provided in the Clang .cdb file. Unfortunately, when using Unreal
Engine, arguments are always generated in a .rsp file (ie.
`/path/to/clang-cl.exe @/path/to/filename_args.rsp`).

After this patch, `/Fo` can be parsed and added to the final
command-line. Without this option, the make targets that are emitted are
made up from the input file name alone. We have some cases where the
same input in the project generates several output files, so we end up
with duplicate make targets in the scan-deps emitted dependency file.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications