[all-commits] [llvm/llvm-project] 942a6a: [llvm-readobj] Fixes malformed json on JSON printe...

[Fred Grim via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 942a6af6ad1d71c8f4219a2d4ab8ca886959c06d
      https://github.com/llvm/llvm-project/commit/942a6af6ad1d71c8f4219a2d4ab8ca886959c06d
  Author: Fred Grim <fgrim at apple.com>
  Date:   2024-05-23 (Thu, 23 May 2024)

  Changed paths:
    M llvm/docs/ReleaseNotes.rst
    M llvm/test/tools/llvm-readobj/ELF/note-core-ntfile.test
    M llvm/tools/llvm-readobj/ELFDumper.cpp

  Log Message:
  -----------
  [llvm-readobj] Fixes malformed json on JSON printed corefiles (#92835)

This patch fixes an issue where, when printing corefile notes with
llvm-readobj as json, the dumper generated llvm formatted output which
isn't valid json. This alters the dumper to, in the NT_FILE, note, dump
properly formatted json data.

Prior to this patch the JSON output was formatted like:
 ```
                "Mapping": [
                  "Start": 4096,
                  "End": 8192,
                  "Offset": 12288,
                  "Filename": "/path/to/a.out"
                ],
 ```
 Whereas now it is formatted as:
  ```
                "Mappings": [
                  {
                    "Start": 4096,
                    "End": 8192,
                    "Offset": 12288,
                    "Filename": "/path/to/a.out"
                  },
  ```
Which is valid. Additionally the LLVM output has changed to match the
structure of the JSON output (i.e. instead of lists of keys it is a list
of dictionaries)



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications