[all-commits] [llvm/llvm-project] 44430d: [Coroutines] Always set the calling convention of ...

Chuanqi Xu via All-commits all-commits at lists.llvm.org
Thu May 23 07:33:15 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 44430de0f117deb09d7391f1cdddd64875486061
      https://github.com/llvm/llvm-project/commit/44430de0f117deb09d7391f1cdddd64875486061
  Author: Chuanqi Xu <yedeng.yd at linux.alibaba.com>
  Date:   2024-05-23 (Thu, 23 May 2024)

  Changed paths:
    M llvm/lib/Transforms/Coroutines/CoroSplit.cpp
    A llvm/test/Transforms/Coroutines/coro-await-suspend-handle-in-ramp.ll

  Log Message:
  -----------
  [Coroutines] Always set the calling convention of generated resuming call from 'llvm.coro.await.suspend.handle' as fast (#93167)

See the post commit message in
https://github.com/llvm/llvm-project/pull/89751

We met a regression due to a change of calling convention of this patch.
Previously, the calling convention of indirect resume calls is always
fast.

And in this patch, although we tried to take care of it in the cloner,
we forget the case that we have to update the resuming calls in the ramp
functions. So this is the root cause of the downstream failure.

This patch tries to mark the generated resuming calls as fast
immediately after they got created to make sure the calling convention
is correct.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list