[all-commits] [llvm/llvm-project] d41dde: LiveRangeEdit: Replace setIsDead with an assert (#...

[Matt Arsenault via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d41dde70c44a10f9761242df73fdd288c4660c8d
      https://github.com/llvm/llvm-project/commit/d41dde70c44a10f9761242df73fdd288c4660c8d
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2024-05-22 (Wed, 22 May 2024)

  Changed paths:
    M llvm/lib/CodeGen/LiveRangeEdit.cpp

  Log Message:
  -----------
  LiveRangeEdit: Replace setIsDead with an assert (#92964)

I noticed this was possibly buggy with implicit operands with the same
dest register, and should maybe be using addRegisterDead. However, this
is never called in a situation where the operand wasn't already marked
dead. This is eliminateDeadDef, implying the def was already known to be
dead.

Add an assert to detect inconsistencies in dead flags. This was
apparently added in 9a16d655c71826bef98b7d6e9590e4494ac0e1a9.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications