[all-commits] [llvm/llvm-project] 89e455: [MLIR][OpenMP] NFC: Split OpenMP dialect definitions

[Sergio Afonso via All-commits]

  Branch: refs/heads/users/skatrak/mlir-clauses-01-refactor
  Home:   https://github.com/llvm/llvm-project
  Commit: 89e4555f41987b4bb3fd6034775f2ef7e08a2060
      https://github.com/llvm/llvm-project/commit/89e4555f41987b4bb3fd6034775f2ef7e08a2060
  Author: Sergio Afonso <safonsof at amd.com>
  Date:   2024-05-20 (Mon, 20 May 2024)

  Changed paths:
    A mlir/include/mlir/Dialect/OpenMP/OpenMPAttrDefs.td
    A mlir/include/mlir/Dialect/OpenMP/OpenMPDialect.td
    A mlir/include/mlir/Dialect/OpenMP/OpenMPEnums.td
    A mlir/include/mlir/Dialect/OpenMP/OpenMPOpBase.td
    M mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td
    M mlir/include/mlir/Dialect/OpenMP/OpenMPOpsInterfaces.td

  Log Message:
  -----------
  [MLIR][OpenMP] NFC: Split OpenMP dialect definitions

This patch splits definitions for the OpenMP dialect into multiple files to
simplify the addition of new features, reduce merge conflicts, make it easier
to understand, etc. The split is based on the structure of the more mature
LLVMIR dialect. More specifically:

- The OpenMP dialect definition is located in OpenMPDialect.td.
- Base classes for OpenMP operations and types, as well as generic OpenMP types
are moved to OpenMPOpBase.td.
- OpenMP enumeration attributes, their case attributes and shared base classes
for these are placed in OpenMPEnums.td.
- Other OpenMP attributes are separated into OpenMPAttrDefs.td.
- OpenMPOps.td only contains operation definitions.

Even though this change should be useful on its own, it is intended as a
precursor to a follow-up PR in which operation arguments and attributes are
split into clause-specific classes which are then shared by all operations to
which they apply to. Without this prior change, that approach would make the
OpenMPOps.td file harder to navigate.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications