[all-commits] [llvm/llvm-project] 84c862: Fix flaky test: signal_in_mutex_lock.cpp

Julian Lettner via All-commits all-commits at lists.llvm.org
Fri May 17 12:13:01 PDT 2024


  Branch: refs/heads/users/signal_in_mutex_lock.cpp-test-fix
  Home:   https://github.com/llvm/llvm-project
  Commit: 84c8627aa10bc7192a88ca0a7543e51f62370e84
      https://github.com/llvm/llvm-project/commit/84c8627aa10bc7192a88ca0a7543e51f62370e84
  Author: Julian Lettner <jlettner at apple.com>
  Date:   2024-05-17 (Fri, 17 May 2024)

  Changed paths:
    M compiler-rt/test/tsan/signal_in_mutex_lock.cpp

  Log Message:
  -----------
  Fix flaky test: signal_in_mutex_lock.cpp

Fix flaky test: the spawned thread keeps spinning
on `sampler_mutex` which may be released before
the thread is terminated based on termination
ordering.

My understanding of C++ semantics are that the
program here is invalid: the destructors of global
variables are invoked at the time of program
termination, and it is the responsibility of the
program to ensure that invoking those destructors
is safe.

rdar://126768628



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list