[all-commits] [llvm/llvm-project] 5d8354: [Flang][OpenMP]Missing convert to lhsType in atomi...

[harishch4 via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5d8354c009d5625fa140be47de1f91275f4698d3
      https://github.com/llvm/llvm-project/commit/5d8354c009d5625fa140be47de1f91275f4698d3
  Author: harishch4 <harishcse44 at gmail.com>
  Date:   2024-05-17 (Fri, 17 May 2024)

  Changed paths:
    M flang/lib/Lower/DirectivesCommon.h
    M flang/test/Lower/OpenMP/atomic-write.f90

  Log Message:
  -----------
  [Flang][OpenMP]Missing convert to lhsType in atomic write (#92346)

Fixes test.f90 in #83144.

This issue is observed only when a boolean constant is assigned to a
logical variable. In non-openmp flow, a conversion op is inserted before
assigning it to a logical variable. This patch will insert a fir.convert
operation when the types are not the same, before generating the atomic
write operation.

I've proposed another patch(#85059 ) which removes checks at MLIR level
and looks like it's too permissive. I'm planning to abandon this patch
and address it here.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications