[all-commits] [llvm/llvm-project] 2f6c0e: [flang][Alias Analysis] not all block arguments ar...

Tom Eccles via All-commits all-commits at lists.llvm.org
Wed May 15 02:26:13 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2f6c0e6e180c81087c26f4afac2155ea70472ec6
      https://github.com/llvm/llvm-project/commit/2f6c0e6e180c81087c26f4afac2155ea70472ec6
  Author: Tom Eccles <tom.eccles at arm.com>
  Date:   2024-05-15 (Wed, 15 May 2024)

  Changed paths:
    M flang/lib/Optimizer/Analysis/AliasAnalysis.cpp
    M flang/lib/Optimizer/Transforms/AddAliasTags.cpp
    M flang/test/Transforms/tbaa.fir

  Log Message:
  -----------
  [flang][Alias Analysis] not all block arguments are dummy arguments (#92156)

Arguments to openmp regions should not be tagged as dummy arguments.
This is particularly unsafe because these openmp blocks will eventually
be inlined into the calling function, where they will trivially alias
with other values inside of the calling function.

This is probably a theoretical issue because the calls to openmp runtime
function calls would act as barriers, preventing optimizations that are
too aggressive. But a lot more thought would need to go into a bet like
that.

This came out of discussion on
https://github.com/llvm/llvm-project/pull/92036



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list