[all-commits] [llvm/llvm-project] 847c83: InstCombine: Process addrspacecast uses in Pointer...

[Matt Arsenault via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 847c83f7cceeaec6676f33291081912d6b8fda5e
      https://github.com/llvm/llvm-project/commit/847c83f7cceeaec6676f33291081912d6b8fda5e
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2024-05-15 (Wed, 15 May 2024)

  Changed paths:
    M llvm/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp
    A llvm/test/Transforms/InstCombine/AMDGPU/issue68120.ll
    M llvm/test/Transforms/InstCombine/ptr-replace-alloca.ll

  Log Message:
  -----------
  InstCombine: Process addrspacecast uses in PointerReplacer (#91953)

This was looking through an addrspacecast, and not finding a later
unfoldable cast to another address space. Fixes improperly deleting
a required alloca + memcpy and introducing an illegal addrspacecast.
    
This also required fixing some worklist management issues with
addrspacecast, and assuming that only memcpy sources could need
replacement.
    
Regresses one test function, but this looks like it optimized
before by accident. It never saw the pointer use by the call
to readonly_callee, which should require insertion of a new cast.
    
Fixes #68120



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications