[all-commits] [llvm/llvm-project] 081775: [RISCV] Improve testing of loads with offset in lo...

[Craig Topper via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 08177541267fff84a96701fc5fc232eb4f12f9d9
      https://github.com/llvm/llvm-project/commit/08177541267fff84a96701fc5fc232eb4f12f9d9
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2024-05-13 (Mon, 13 May 2024)

  Changed paths:
    M llvm/test/CodeGen/RISCV/local-stack-slot-allocation.ll

  Log Message:
  -----------
  [RISCV] Improve testing of loads with offset in local-stack-slot-allocation.ll. NFC

The test we had didn't match it's description.

Now we have one test with a large offset that requires a virtual base register
and a test with a smaller offset that should not.

There is currently a bug that causes the offset to double counted
leading to the small case also using a virtual base register.


  Commit: 026686bac606ac03d688a44f2ea4cb829d7b08bc
      https://github.com/llvm/llvm-project/commit/026686bac606ac03d688a44f2ea4cb829d7b08bc
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2024-05-13 (Mon, 13 May 2024)

  Changed paths:
    M llvm/lib/Target/RISCV/RISCVRegisterInfo.cpp
    M llvm/test/CodeGen/RISCV/local-stack-slot-allocation.ll

  Log Message:
  -----------
  [RISCV] Don't add getFrameIndexInstrOffset in RISCVRegisterInfo::needsFrameBaseReg.

It's already added in isFrameOffsetLegal so adding it in needsFrameBaseReg
causes it to be double counted.


Compare: https://github.com/llvm/llvm-project/compare/d03a1a6e5838...026686bac606

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications