[all-commits] [llvm/llvm-project] 0bacff: [mlir][vector] Update tests/patterns for vector.tr...

[Andrzej Warzyński via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0bacffbbfc081b4147ac935512e2c5da9e3c06f0
      https://github.com/llvm/llvm-project/commit/0bacffbbfc081b4147ac935512e2c5da9e3c06f0
  Author: Andrzej Warzyński <andrzej.warzynski at arm.com>
  Date:   2024-05-13 (Mon, 13 May 2024)

  Changed paths:
    M mlir/lib/Dialect/Vector/Transforms/LowerVectorTranspose.cpp
    A mlir/test/Dialect/Vector/CPU/X86/vector-transpose-lowering.mlir
    M mlir/test/Dialect/Vector/vector-transpose-lowering.mlir

  Log Message:
  -----------
  [mlir][vector] Update tests/patterns for vector.transpose (#91359)

Pretty much all logic that we have today for lowering vector.transpose
assumes fixed length vectors (it's done via vector.shuffle that don't
support scalable vectors). This patch updates related tests and patterns
to capture and document this limitation more explicitly.

Note that `vector.transpose` is a valid operation in the context of
scalable vectors, but we are yet to implement the missing lowerings.

Summary of changes:
* `@transpose_nx8x2xf32` is renamed as `@transpose_scalabl`e
  and moved near other tests using `lowering_strategy = "shuffle_1d"
  (to avoid duplicating TD sequences)
* tests specific to X86  (`avx2_lowering_strategy = true`) are moved to
  a dedicated file (to separate generic tests from target-specific
  tests)
* `@transpose10_nx4xnx1xf32` duplicated `@transpose10_4xnx1xf32` and was
  deleted (the latter is renamed as `@transpose10_4x1xf32_scalable` to
  match its fixed-width counterpart: `@transpose10_4x1xf32`)



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications