[all-commits] [llvm/llvm-project] 1aca8e: [lldb][ELF] Add a comment to explain address class...

[David Spickett via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1aca8ed5a7eeed264fdc2694deca8a4a4dba3689
      https://github.com/llvm/llvm-project/commit/1aca8ed5a7eeed264fdc2694deca8a4a4dba3689
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2024-05-10 (Fri, 10 May 2024)

  Changed paths:
    M lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.h

  Log Message:
  -----------
  [lldb][ELF] Add a comment to explain address class map type

It was pointed out that ordering is crucial here, so note that.

I also looked into using a vector instead, as described in
https://llvm.org/docs/ProgrammersManual.html#dss-sortedvectorset.

Which this is in theory perfect for, but we have at least 2 places
that update the map and both would need to sort/unique each time.
Plus this code is pretty bug prone.

If there is future refactoring it's one thing to consider.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications