[all-commits] [llvm/llvm-project] 41f057: [HLSL] reenable add packoffset in AST (#91474)

[Xiang Li via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 41f0574c4654fb8a8cbb8c26d453f51a31cfd2a0
      https://github.com/llvm/llvm-project/commit/41f0574c4654fb8a8cbb8c26d453f51a31cfd2a0
  Author: Xiang Li <python3kgae at outlook.com>
  Date:   2024-05-09 (Thu, 09 May 2024)

  Changed paths:
    M clang/include/clang/Basic/Attr.td
    M clang/include/clang/Basic/AttrDocs.td
    M clang/include/clang/Basic/DiagnosticGroups.td
    M clang/include/clang/Basic/DiagnosticParseKinds.td
    M clang/include/clang/Basic/DiagnosticSemaKinds.td
    M clang/lib/Parse/ParseHLSL.cpp
    M clang/lib/Sema/SemaDeclAttr.cpp
    M clang/lib/Sema/SemaHLSL.cpp
    A clang/test/AST/HLSL/packoffset.hlsl
    A clang/test/SemaHLSL/packoffset-invalid.hlsl

  Log Message:
  -----------
  [HLSL] reenable add packoffset in AST (#91474)

This reapplies
https://github.com/llvm/llvm-project/commit/c5509fedc5757fffece385d9d068e36b26793ade
"[HLSL] Support packoffset attribute in AST
(https://github.com/llvm/llvm-project/pull/89836)" with a fix for the
test failure caused by missing -fnative-half-type.

Since we have to parse the attribute manually in ParseHLSLAnnotations,
we could create the ParsedAttribute with an integer offset parameter
instead of string. This approach avoids parsing the string if the offset
is saved as a string in HLSLPackOffsetAttr.

For #57914



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications