[all-commits] [llvm/llvm-project] dabdec: Fix `memref.expand_shape` verifier (#91501)

[Benoit Jacob via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: dabdec1001dc368373dd581cf72f37a440873ce3
      https://github.com/llvm/llvm-project/commit/dabdec1001dc368373dd581cf72f37a440873ce3
  Author: Benoit Jacob <jacob.benoit.1 at gmail.com>
  Date:   2024-05-08 (Wed, 08 May 2024)

  Changed paths:
    M mlir/lib/Dialect/MemRef/IR/MemRefOps.cpp
    M mlir/test/Dialect/MemRef/fold-memref-alias-ops.mlir
    M mlir/test/Dialect/MemRef/ops.mlir

  Log Message:
  -----------
  Fix `memref.expand_shape` verifier (#91501)

Torch-mlir integration is currently blocked on `memref.expand_shape`
verifier errors of the form

```
'memref.expand_shape' op invalid output shape provided at pos 1
```

The verifier code generating these errors was introduced in
https://github.com/llvm/llvm-project/pull/91245. I have commented there
why I believe it's incorrect. This PR has my suggested fix.

Unfortunately, this does not seem to be directly testable on `memref`
IR, because `static_output_shape` is not directly exposed in the custom
assembly format.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications