[all-commits] [llvm/llvm-project] 2ad691: [modules] Accept equivalent module caches from dif...

Ellis Hoag via All-commits all-commits at lists.llvm.org
Tue May 7 13:56:06 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2ad6917c4c524576405f2146424911fd9adb3528
      https://github.com/llvm/llvm-project/commit/2ad6917c4c524576405f2146424911fd9adb3528
  Author: Ellis Hoag <ellis.sparky.hoag at gmail.com>
  Date:   2024-05-07 (Tue, 07 May 2024)

  Changed paths:
    M clang/lib/Serialization/ASTReader.cpp
    A clang/test/Modules/module-symlink.m
    M llvm/include/llvm/Support/VirtualFileSystem.h
    M llvm/lib/Support/VirtualFileSystem.cpp

  Log Message:
  -----------
  [modules] Accept equivalent module caches from different symlink (#90925)

Use `VFS.equivalent()`, which follows symlinks, to check if two module
cache paths are equivalent. This prevents a PCH error when building from
a different path that is a symlink of the original.

```
error: PCH was compiled with module cache path '/home/foo/blah/ModuleCache/2IBP1TNT8OR8D', but the path is currently '/data/users/foo/blah/ModuleCache/2IBP1TNT8OR8D'
1 error generated.
```



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list