[all-commits] [llvm/llvm-project] 0348e7: [clang][dataflow] Fix crash when `operator=` resul...

[martinboehme via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0348e71885ee8c07e1ae789059ff6d3c9ffce596
      https://github.com/llvm/llvm-project/commit/0348e71885ee8c07e1ae789059ff6d3c9ffce596
  Author: martinboehme <mboehme at google.com>
  Date:   2024-05-06 (Mon, 06 May 2024)

  Changed paths:
    M clang/lib/Analysis/FlowSensitive/Transfer.cpp
    M clang/unittests/Analysis/FlowSensitive/TransferTest.cpp

  Log Message:
  -----------
  [clang][dataflow] Fix crash when `operator=` result type is not destination type. (#90898)

The existing code was full of comments about how we assume this is
always the
case, but it's not mandated by the standard, and there is code out there
that
returns a different type. So check that the result type is in fact the
same as
the destination type before attempting to copy to the result.

To make sure that we don't bail out in more cases than intended, I've
extended
existing tests to verify that in the common case, we do return the
destination
object (by reference or value, as the case may be).



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications