[all-commits] [llvm/llvm-project] 3cbfc9: [mlir][ODS][NFC] Deduplicate `ref` and `qualified`...

Markus Böck via All-commits all-commits at lists.llvm.org
Sat May 4 12:57:44 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3cbfc9d80b35b90910de2953d72d7df4bd43e4cf
      https://github.com/llvm/llvm-project/commit/3cbfc9d80b35b90910de2953d72d7df4bd43e4cf
  Author: Markus Böck <markus.boeck02 at gmail.com>
  Date:   2024-05-04 (Sat, 04 May 2024)

  Changed paths:
    M mlir/test/mlir-tblgen/attr-or-type-format-invalid.td
    M mlir/tools/mlir-tblgen/AttrOrTypeFormatGen.cpp
    M mlir/tools/mlir-tblgen/FormatGen.cpp
    M mlir/tools/mlir-tblgen/FormatGen.h
    M mlir/tools/mlir-tblgen/OpFormatGen.cpp

  Log Message:
  -----------
  [mlir][ODS][NFC] Deduplicate `ref` and `qualified` handling (#91080)

Both the attribute and type format generator and the op format generator
independently implemented the parsing and verification of the `ref` and
`qualified` directives with little to no differences.

This PR moves the implementation of these into the common `FormatParser`
class to deduplicate the implementations.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list