[all-commits] [llvm/llvm-project] f16e23: [InstCombine] Do not request non-splat vector supp...

[Nikita Popov via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f16e234f1126f6646609b6918a37c8eb32c8fb3e
      https://github.com/llvm/llvm-project/commit/f16e234f1126f6646609b6918a37c8eb32c8fb3e
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2024-05-04 (Sat, 04 May 2024)

  Changed paths:
    M llvm/docs/InstCombineContributorGuide.md

  Log Message:
  -----------
  [InstCombine] Do not request non-splat vector support in code reviews (NFC) (#90709)

The InstCombine contributor guide already says:

> Handle non-splat vector constants if doing so is free, but do
> not add handling for them if it adds any additional complexity
> to the code.

This change strengthens this guideline to explicitly discourage
asking (new) contributors to implement non-splat support during code
reviews. Doing so will almost certainly increase the number of
necessary review iterations, or result in outright contradictory review
feedback, as different people are willing to accept a different degree
of complexity for non-splat vector support.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications