[all-commits] [llvm/llvm-project] 385faf: [ARM/X86] Standardize the isEligibleForTailCallOpt...

Reid Kleckner via All-commits all-commits at lists.llvm.org
Fri May 3 13:57:16 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 385faf9cdefeed5a2f51072d227842be0e36135c
      https://github.com/llvm/llvm-project/commit/385faf9cdefeed5a2f51072d227842be0e36135c
  Author: Reid Kleckner <rnk at google.com>
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
    M llvm/lib/Target/ARM/ARMISelLowering.cpp
    M llvm/lib/Target/ARM/ARMISelLowering.h
    M llvm/lib/Target/X86/X86ISelLowering.h
    M llvm/lib/Target/X86/X86ISelLoweringCall.cpp

  Log Message:
  -----------
  [ARM/X86] Standardize the isEligibleForTailCallOptimization prototypes (#90688)

Pass in CallLoweringInfo (CLI) instead of passing in the various fields
directly. Also pass in CCState (CCInfo), which is computed in both the
caller and the callee for a minor efficiency saving. There may also be a
small correctness improvement for sibcalls with vectorcall, which has an
odd way of recomputing argument locations.

This is a step towards improving the handling of musttail on armv7,
which we have numerous issues filed about in our tracker.

I took inspiration for this from the RISCV tail call eligibility check,
which uses a similar prototype.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list