[all-commits] [llvm/llvm-project] 9c8b0d: Use FileCheck in new clang-tidy/infrastructure/con...

Hans via All-commits all-commits at lists.llvm.org
Fri May 3 06:10:45 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9c8b0d4ef6308ca0a74151c14c01f972e8db8cda
      https://github.com/llvm/llvm-project/commit/9c8b0d4ef6308ca0a74151c14c01f972e8db8cda
  Author: Hans Wennborg <hans at chromium.org>
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
    M clang-tools-extra/test/clang-tidy/infrastructure/config-files.cpp

  Log Message:
  -----------
  Use FileCheck in new clang-tidy/infrastructure/config-files.cpp tests

The test was failing spuriously on some machines [1]. Converting from
grep to FileCheck makes it easier to see what's happening, and also grep
is discouraged in tests [2].

Also drop the negative test: checking for the expected output is better.

 1. https://crbug.com/338535754
 2. https://llvm.org/docs/TestingGuide.html#:~:text=.%20%5BThe-,usage%20of%20grep,-in%20RUN%20lines



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list