[all-commits] [llvm/llvm-project] 5850f6: [Flang][OpenMP] Parse and semantically analyze com...

[agozillon via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5850f6ba9b2c14d8457c6e8455483a20b2bf3636
      https://github.com/llvm/llvm-project/commit/5850f6ba9b2c14d8457c6e8455483a20b2bf3636
  Author: agozillon <Andrew.Gozillon at amd.com>
  Date:   2024-05-03 (Fri, 03 May 2024)

  Changed paths:
    M flang/lib/Semantics/resolve-directives.cpp
    M flang/test/Semantics/OpenMP/map-clause.f90

  Log Message:
  -----------
  [Flang][OpenMP] Parse and semantically analyze common blocks in map clauses correctly (#89847)

Currently, you cannot provide the common block syntax that you should be
able to provide for map clauses (and that you can for declare target)
e.g.:

` !$omp target map(tofrom: /var/)`

This PR seeks to change that and allow this syntax via a small tweak,
which may also allow a wider range of types to be provided without issue
as well via the utilisation of ResolveOmpObject a helper function used
by the majority of other OmpObject handling clauses.

A by product of this change, is that we now emit an error for the
following syntax, when provided to map clauses with an assumed size
array:

`!$omp target map(arr(:))`

This seems inline with the specification from what I understand of it
(do feel free to correct me if that is not your reading or I am
incorrect!) and other OpenMP compilers i.e. gfortran, ifx, ifort.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications