[all-commits] [llvm/llvm-project] 82f72c: [clang][Sema] Re-use existing BinaryOperator if po...

[Youngsuk Kim via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 82f72c1aa8ef36b521a617a291c9f732edca9d12
      https://github.com/llvm/llvm-project/commit/82f72c1aa8ef36b521a617a291c9f732edca9d12
  Author: Youngsuk Kim <joseph942010 at gmail.com>
  Date:   2024-05-02 (Thu, 02 May 2024)

  Changed paths:
    M clang/docs/ReleaseNotes.rst
    M clang/lib/Sema/SemaExpr.cpp
    M clang/test/CXX/drs/dr7xx.cpp

  Log Message:
  -----------
  [clang][Sema] Re-use existing BinaryOperator if possible (#90625)

First round of Sema checks were run at initial parsing step. Creating a
new BinaryOperator instance (with the re-built LHS or RHS) will trigger
another round of Sema checks, which can lead to duplicate diagnostic
warning messages.

All we want here is to replace the LHS or RHS with a NonOdrUse version.
Don't create a new BinaryOperator, but simply replace the LHS or RHS of
the given BinaryOperator.

Fixes #45783



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications