[all-commits] [llvm/llvm-project] d1b364: [flang] always run PolymorphicOpConversion sequent...

[Tom Eccles via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d1b3648ed9da1ea8f1ca62a150b519f9d08fffaf
      https://github.com/llvm/llvm-project/commit/d1b3648ed9da1ea8f1ca62a150b519f9d08fffaf
  Author: Tom Eccles <tom.eccles at arm.com>
  Date:   2024-05-01 (Wed, 01 May 2024)

  Changed paths:
    M flang/include/flang/Optimizer/Transforms/Passes.td
    M flang/include/flang/Tools/CLOptions.inc
    M flang/lib/Optimizer/Transforms/PolymorphicOpConversion.cpp
    M flang/test/Driver/bbc-mlir-pass-pipeline.f90
    M flang/test/Driver/mlir-debug-pass-pipeline.f90
    M flang/test/Driver/mlir-pass-pipeline.f90
    M flang/test/Fir/basic-program.fir

  Log Message:
  -----------
  [flang] always run PolymorphicOpConversion sequentially (#90721)

It was pointed out in post commit review of
https://github.com/llvm/llvm-project/pull/90597 that the pass should
never have been run in parallel over all functions (and now other top
level operations) in the first place. The mutex used in the pass was
ineffective at preventing races since each instance of the pass would
have a different mutex.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications