[all-commits] [llvm/llvm-project] 19f4d6: [GlobalISel] Fix store merging incorrectly classif...

[Amara Emerson via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 19f4d68252b70c81ebb1686a5a31069eda5373de
      https://github.com/llvm/llvm-project/commit/19f4d68252b70c81ebb1686a5a31069eda5373de
  Author: Amara Emerson <amara at apple.com>
  Date:   2024-04-30 (Tue, 30 Apr 2024)

  Changed paths:
    M llvm/include/llvm/CodeGen/GlobalISel/LoadStoreOpt.h
    M llvm/lib/CodeGen/GlobalISel/LoadStoreOpt.cpp
    M llvm/test/CodeGen/AArch64/GlobalISel/store-merging.ll
    M llvm/test/CodeGen/AArch64/GlobalISel/store-merging.mir

  Log Message:
  -----------
  [GlobalISel] Fix store merging incorrectly classifying an unknown index expr as 0. (#90375)

During analysis, we incorrectly leave the offset part of an address info
struct
as zero, when in actual fact we failed to decompose it into base +
offset.
This results in incorrectly assuming that the address is adjacent to
another store
addr. To fix this we wrap the offset in an optional<> so we can
distinguish between
real zero and unknown.

Fixes issue #90242



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications